736: Changed discord message to have leaderboard ID#733
736: Changed discord message to have leaderboard ID#733Arshadul-Monir wants to merge 5 commits intomainfrom
Conversation
Available PR Commands
See: https://github.com/tahminator/codebloom/wiki/CI-Commands |
Title736: Changed discord message to have leaderboard ID PR TypeBug fix Description
Diagram Walkthroughflowchart LR
DCM["DiscordClubManager.java"]
Completed["sendLeaderboardCompletedDiscordMessage"]
Weekly["sendWeeklyLeaderboardUpdateDiscordMessage"]
URL["/leaderboard/{leaderboardId}?{tag}=true"]
DCM -- updates --> Completed
DCM -- updates --> Weekly
Completed -- formats link --> URL
Weekly -- formats link --> URL
|
| Relevant files | |||
|---|---|---|---|
| Bug fix |
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
src/main/java/org/patinanetwork/codebloom/common/components/DiscordClubManager.java
Show resolved
Hide resolved
src/main/java/org/patinanetwork/codebloom/common/components/DiscordClubManager.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
This PR aims to add leaderboard IDs to Discord message URLs and replace hardcoded production URLs with dynamic URLs from ServerUrlUtils. However, the implementation is incomplete - while the leaderboard ID parameter was added, the hardcoded production URL was not replaced with the dynamic URL as stated in the PR description.
Changes:
- Added leaderboard ID as a path parameter to Discord message URLs
- Added new format placeholders and corresponding parameters for leaderboard IDs in both completion and weekly update messages
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/org/patinanetwork/codebloom/common/components/DiscordClubManager.java
Outdated
Show resolved
Hide resolved
src/main/java/org/patinanetwork/codebloom/common/components/DiscordClubManager.java
Outdated
Show resolved
Hide resolved
src/main/java/org/patinanetwork/codebloom/common/components/DiscordClubManager.java
Show resolved
Hide resolved
src/main/java/org/patinanetwork/codebloom/common/components/DiscordClubManager.java
Show resolved
Hide resolved
|
/deploy |
|
The command to deploy to staging for the commit 9842ef5 has been triggered. View action run |
|
/deploy |
|
The command to deploy to staging for the commit 706567b has been triggered. View action run |
|
|
|
/copy |
|
Database copy command completed successfully! |
04672c8 to
8bc0ff2
Compare
|
/deploy |
1 similar comment
|
/deploy |
|
/deploy |
1 similar comment
|
/deploy |
|
/copy |
|
Database copy command completed successfully! |



736
Description of changes
Added the leaderboard ID to the url message + replaced the hardcoded prod url with ServerUrlUtils url
Checklist before review
Screenshots
Dev
Staging